1. 1//! Learning-loop tool classification (docs/design/26-learning.md):
2. 2//! journaling tools are sanctioned under workspace-write, denied by
3. 3//! read-only; session_search is a read everywhere reads are allowed.
4. 4
5. 5#![allow(clippy::unwrap_used, clippy::expect_used)]
6. 6
7. 7use serde_json::json;
8. 8use vak_permission::{Mode, PermissionEngine};
9. 9
10. 10#[test]
11. 11fn learning_tools_allowed_under_workspace_write_without_rules() {
12. 12 let engine = PermissionEngine::default();
13. 13 for tool in ["remember", "propose_skill"] {
14. 14 let d = engine.evaluate(
15. 15 tool,
16. 16 &json!({}),
17. 17 Mode::WorkspaceWrite,
18. 18 std::path::Path::new("/ws"),
19. 19 );
20. 20 assert!(
21. 21 matches!(d, vak_permission::Decision::Allow),
22. 22 "{tool} must not require approval: {d:?}"
23. 23 );
24. 24 }
25. 25}
26. 26
27. 27#[test]
28. 28fn remember_denied_in_read_only() {
29. 29 let engine = PermissionEngine::default();
30. 30 let d = engine.evaluate(
31. 31 "remember",
32. 32 &json!({}),
33. 33 Mode::ReadOnly,
34. 34 std::path::Path::new("/ws"),
35. 35 );
36. 36 assert!(matches!(d, vak_permission::Decision::Deny { .. }), "{d:?}");
37. 37}
38. 38
39. 39#[test]
40. 40fn session_search_is_a_read() {
41. 41 let engine = PermissionEngine::default();
42. 42 for mode in [Mode::ReadOnly, Mode::WorkspaceWrite] {
43. 43 let d = engine.evaluate(
44. 44 "session_search",
45. 45 &json!({"query": "x"}),
46. 46 mode,
47. 47 std::path::Path::new("/ws"),
48. 48 );
49. 49 assert!(
50. 50 matches!(d, vak_permission::Decision::Allow),
51. 51 "{mode:?}: {d:?}"
52. 52 );
53. 53 }
54. 54}
55. 55
56. 56/// Reading the Agent's own portfolio changes nothing. Found in a live run:
57. 57/// "what commitments are you holding?" on an unattended surface was refused
58. 58/// because the read needed an approver nobody could be.
59. 59#[test]
60. 60fn commitments_is_a_read() {
61. 61 let engine = PermissionEngine::default();
62. 62 for mode in [Mode::ReadOnly, Mode::WorkspaceWrite] {
63. 63 let d = engine.evaluate(
64. 64 "commitments",
65. 65 &json!({"include_closed": true}),
66. 66 mode,
67. 67 std::path::Path::new("/ws"),
68. 68 );
69. 69 assert!(
70. 70 matches!(d, vak_permission::Decision::Allow),
71. 71 "{mode:?}: {d:?}"
72. 72 );
73. 73 }
74. 74 // An operator's rule still wins.
75. 75 let engine = PermissionEngine::from_rule_strings(&["-commitments".to_string()]).unwrap();
76. 76 let d = engine.evaluate(
77. 77 "commitments",
78. 78 &json!({}),
79. 79 Mode::WorkspaceWrite,
80. 80 std::path::Path::new("/ws"),
81. 81 );
82. 82 assert!(matches!(d, vak_permission::Decision::Deny { .. }), "{d:?}");
83. 83}
84. 84
85. 85#[test]
86. 86fn explicit_deny_rule_still_beats_learning_allowance() {
87. 87 // Severity aggregation: a user's deny rule outranks the built-in
88. 88 // WorkspaceWrite allowance.
89. 89 let engine = PermissionEngine::from_rule_strings(&["-remember".to_string()]).unwrap();
90. 90 let d = engine.evaluate(
91. 91 "remember",
92. 92 &json!({}),
93. 93 Mode::WorkspaceWrite,
94. 94 std::path::Path::new("/ws"),
95. 95 );
96. 96 assert!(matches!(d, vak_permission::Decision::Deny { .. }), "{d:?}");
97. 97}
98. 98